From: Keir Fraser Date: Wed, 17 Jun 2009 06:23:06 +0000 (+0100) Subject: xenconsole: fix assumption about printed max domid length. X-Git-Tag: archive/raspbian/4.8.0-1+rpi1~1^2~13752 X-Git-Url: https://dgit.raspbian.org/%22http://www.example.com/cgi/success//%22http:/www.example.com/cgi/success/?a=commitdiff_plain;h=ac663c94f046161c0753ccf91455c3fbd3f50d1a;p=xen.git xenconsole: fix assumption about printed max domid length. Also snprintf includes the final '\0' in the char count. Signed-off-by: Stefano Stabellini --- diff --git a/tools/console/client/main.c b/tools/console/client/main.c index b66baf8ae6..63e729acab 100644 --- a/tools/console/client/main.c +++ b/tools/console/client/main.c @@ -306,10 +306,10 @@ int main(int argc, char **argv) dom_path = xs_get_domain_path(xs, domid); if (dom_path == NULL) err(errno, "xs_get_domain_path()"); - path = malloc(strlen(dom_path) + strlen("/serial/0/tty") + 3); + path = malloc(strlen(dom_path) + strlen("/serial/0/tty") + 5); if (path == NULL) err(ENOMEM, "malloc"); - snprintf(path, strlen(dom_path) + strlen("/serial/0/tty") + 2, "%s/serial/%d/tty", dom_path, num); + snprintf(path, strlen(dom_path) + strlen("/serial/0/tty") + 5, "%s/serial/%d/tty", dom_path, num); /* FIXME consoled currently does not assume domain-0 doesn't have a console which is good when we break domain-0 up. To keep us